Rollback python_on_whales conversion #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanejbrown
force-pushed
the
rollback_python_on_whales
branch
2 times, most recently
from
2977fb3 to
6f85a5f
Compare
tamagoko
approved these changes
Nov 5, 2024
shanejbrown
force-pushed
the
rollback_python_on_whales
branch
from
6f85a5f to
c13f4a9
Compare
shanejbrown
force-pushed
the
rollback_python_on_whales
branch
from
c13f4a9 to
28fcaae
Compare
bluesliverx
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Rollback previous attempts to convert
docker-pycalls withpython-on-whales, except for building multi-platform images which is not possible withdocker-py. It was determined that the pitfalls and current limitations with python-on-whales that it was worth the effort to convert totally over to it at this time. The PR rollbacks those changes in a single commit to make the code more concise and readable.What issues does this PR fix or reference?
Previous Behavior
New Behavior
Merge requirements satisfied?
setup.py(if appropriate).